Clean up IWindow and remove platform-agnostic code probing ISDLWindow
#6438
Conversation
It's equivalent to `IsActive`.
Only implemented on Windows, and have no real use. ISDLWindow.Position can be used for the same purpose.
Moves those that were used in platform-agnostic code and tests.
Susko3
force-pushed
the
clean-up-IWindow
branch
from
fe74e25
to
f0824e2
Compare
| Point windowLocation; | ||
|
|
||
| switch (Host.Window.WindowMode.Value) | ||
| { | ||
| case WindowMode.Windowed: | ||
| windowLocation = Host.Window is ISDLWindow sdlWindow ? sdlWindow.Position : Point.Empty; | ||
| break; | ||
|
|
||
| default: | ||
| windowLocation = Host.Window.CurrentDisplayBindable.Value.Bounds.Location; | ||
| break; | ||
| } |
There was a problem hiding this comment.
I think it's best to do this change in a separate PR and keep this PR as a completely code-quality change. I wouldn't be comfortable to merge this without seeing it being tested on all platforms we have (testing the fact that host.Window.Position = host.Window.CurrentDisplayBindable.Value.Bounds.Location on non-windowed mode).
|
If we're obsoleting Usually the CIs would've errored out if an obsolete member is being used somewhere, but it looks like applying the attribute to an interface member does not make that happen for some reason. The attribute should be copied to the class implementations as well in order to be effective. |
|
This inner usage is fine, I would like to remove it just from the interface (and the base |
|
Sure, didn't notice the implementations were internal. |
Focused,PointToClient()andPointToScreen()inIWindoware made obsolete as they are not useful. See commits for more details.Moves some members from
ISDLWindowtoIWindow. This makes it so platform-agnostic code no longer needs to cast toISDLWindow(inUserInputManagerand tests).