Remove pybind submodule, move to pyproject.toml #903
+72
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hugo KULESZA <[email protected]>
Signed-off-by: Hugo KULESZA <[email protected]>
Signed-off-by: Hugo KULESZA <[email protected]>
Signed-off-by: Hugo KULESZA <[email protected]>
Signed-off-by: Hugo KULESZA <[email protected]>
Signed-off-by: Hugo KULESZA <[email protected]>
Signed-off-by: Hugo KULESZA <[email protected]>
Signed-off-by: Hugo KULESZA <[email protected]>
Signed-off-by: Hugo KULESZA <[email protected]>
Signed-off-by: Hugo KULESZA <[email protected]>
Signed-off-by: Hugo KULESZA <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Technical upgrade
What is the current behavior?
pybind11 is currently used as a git submodule in the cpp folder, and the setuptools build is configured using setup.cfg.
What is the new behavior (if this is a feature change)?
This PR moves the configuration of the build in a pyproject.toml file (more modern and that uses an isolated environment to build), and removes the git submodule by replacing it using a python dependency and cmake find_package directive.
Does this PR introduce a breaking change or deprecate an API?