Lint GitHub Action workflows

ponylang · Aug 10, 2023 · 568e79f · 568e79f
1 parent 83e76aa
commit 568e79f
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 7 deletions.
diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -7,6 +7,17 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  actionlint:
+    name: Lint GitHub Action Workflows
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+      - name: Check workflow files
+        uses: docker://ponylang/shared-docker-ci-actionlint:20230810
+        with:
+          args: -color
+
   lint-entrypoint-py:
     name: Lint entrypoint.py
     runs-on: ubuntu-latest

diff --git a/.github/workflows/update-latest-image.yml b/.github/workflows/update-latest-image.yml
@@ -18,7 +18,7 @@ jobs:
       - name: Checkout source
         uses: actions/checkout@v3
       - name: Login to Docker Hub
-        run: "docker login -u $DOCKER_USERNAME -p $DOCKER_PASSWORD"
+        run: docker login -u "$DOCKER_USERNAME" -p "$DOCKER_PASSWORD"
         env:
           DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
           DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}

diff --git a/.github/workflows/update-release-image.yml b/.github/workflows/update-release-image.yml
@@ -18,7 +18,7 @@ jobs:
       - name: Checkout source
         uses: actions/checkout@v3
       - name: Login to Docker Hub
-        run: "docker login -u $DOCKER_USERNAME -p $DOCKER_PASSWORD"
+        run: docker login -u "$DOCKER_USERNAME" -p "$DOCKER_PASSWORD"
         env:
           DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
           DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
@@ -78,16 +78,16 @@ jobs:
       - name: Checkout source
         uses: actions/checkout@v3
       - name: Login to Docker Hub
-        run: "docker login -u $DOCKER_USERNAME -p $DOCKER_PASSWORD"
+        run: docker login -u "$DOCKER_USERNAME" -p "$DOCKER_PASSWORD"
         env:
           DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
           DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
       - name: Build
-        run: make build version=${VERSION} config=public
+        run: make build version="${VERSION}" config=public
         env:
           VERSION: ${{ github.event.client_payload.version }}
       - name: Push
-        run: make push version=${VERSION} config=public
+        run: make push version="${VERSION}" config=public
         env:
           VERSION: ${{ github.event.client_payload.version }}
       - name: Send alert on failure
@@ -118,12 +118,12 @@ jobs:
           username: ${{ github.repository_owner }}
           password: ${{ secrets.GITHUB_TOKEN }}
       - name: Build
-        run: make build version=${VERSION} config=private
+        run: make build version="${VERSION}" config=private
         env:
           VERSION: ${{ github.event.client_payload.version }}
           MATERIAL_INSIDERS_ACCESS: ${{ secrets.MATERIAL_INSIDERS_ACCESS }}
       - name: Push
-        run: make push version=${VERSION} config=private
+        run: make push version="${VERSION}" config=private
         env:
           VERSION: ${{ github.event.client_payload.version }}
       - name: Send alert on failure