-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for province/state-level timeseries data #13
Conversation
- add new function `buildSeries` to extract main parsing logic - create new files `province-${country}.json` for the relevant countries Addresses half of pomber#9
Hey @titaniumbones , thanks a lot for the PR. I'm not sure about having one file per country. I know it makes it easier and faster to download if you are interested in only one country, but country names aren't very stable and having multiple files makes it more difficult to maintain. What do you think of putting all the regions in one big file? we could also add the lat-long there:
|
I have no objection at all - might not be able to work on it for next 36 hour, though. I think there's still some benefit to having the let country totals stored directly though, could we keep those? And are you worried about breaking the existing sites that use the library?
On Mar. 18, 2020 9:34 p.m., Rodrigo Pombo <[email protected]> wrote:
Hey @titaniumbones<https://github.com/titaniumbones> , thanks a lot for the PR.
I'm not sure about having one file per country. I know it makes it easier and faster to download if you are interested in only one country, but country names aren't very stable and having multiple files makes it more difficult to maintain.
What do you think of putting all the regions in one big file? we could also add the lat-long there:
{
"Cameroon": {
"Cameroon": {
lat: 3.4,
long: 11.5,
cases: [
{date: .., confirmed: .., deaths: .., recovered: ..},
{date: .., confirmed: .., deaths: .., recovered: ..},
...
]
}
}
"Canada": {
"Ontario": {
lat: 51,
long: -85,
cases: [
{date: .., confirmed: .., deaths: .., recovered: ..},
{date: .., confirmed: .., deaths: .., recovered: ..},
...
]
},
"Alberta": {
lat: 53,
long: -116,
cases: [
{date: .., confirmed: .., deaths: .., recovered: ..},
{date: .., confirmed: .., deaths: .., recovered: ..},
...
]
},
...
},
...
}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#13 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AACY6NHY7K564S7SDFVSRATRIFZATANCNFSM4LOYHVXA>.
|
I started putting together https://labs.braniecki.net/covid19-timeseries/ based on your data. per-region data would be awesome to have. Thank you! |
I would suggest the following: today you have one file name timeseries.json which in fact represent the aggregated data by country. I suggest to create the files:
I did that in my own dash board: http://covid-by-contries.alwaysdata.net/, https://github.com/flccrakers/covid-19. |
sort of bouncing off of what @flccrakers is saying... something i've struggled with the adapters on this dataset is that when i search for say, the united states, i can only get it on a grandular level, and i have to sum up all of the states to get a final total population. i really like how this dataset just has the US alone: so, if we are to add in breakdowns by state, can we still keep an entry for the entire country as a whole? |
Yeah exactly what I suggest. Keep the aggregated data by country and add an other set of data for provinces, when you want to access more details datas ;-) |
@titaniumbones I like your suggestion to have separate files. I'm building a dashboard of just US and would love to have a per-state breakdown without need to request all the data. Were you able to get actions working on your repo? I might fork it. |
Yes, you can fork it or just use my GitHub io if you like. Actions were simple once @pomber explained it.
I think thought that for the is corvidtracking.org might have cleaner data, maybe check it out?
On Mar. 22, 2020 9:01 p.m., Kyle Venn <[email protected]> wrote:
@titaniumbones<https://github.com/titaniumbones> I like your suggestion to have separate files. I'm building a dashboard of just US and would love to have a per-state breakdown without need to request all the data.
Were you able to get actions working on your repo? I might fork it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#13 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AACY6NER4UNQYFXRYO6AKKDRI2YF5ANCNFSM4LOYHVXA>.
|
Oh nice! @titaniumbones so is your fork actively being updated with real information? I'd love to point at |
I think so - haven't been able to work on it and on my phone rn but check commit history, should be mostly automated updates in last 3 days.
On Mar. 22, 2020 10:20 p.m., Kyle Venn <[email protected]> wrote:
Oh nice! @titaniumbones<https://github.com/titaniumbones> so is your fork actively being updated with real information?
I'd love to point at https://titaniumbones.github.io/covid19/timeseries.json it if you're going to keep it up!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#13 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AACY6NHVMUUY6C2PNG2LPO3RI3BQRANCNFSM4LOYHVXA>.
On Mar. 22, 2020 10:20 p.m., Kyle Venn <[email protected]> wrote:
Oh nice! @titaniumbones<https://github.com/titaniumbones> so is your fork actively being updated with real information?
I'd love to point at https://titaniumbones.github.io/covid19/timeseries.json it if you're going to keep it up!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#13 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AACY6NHVMUUY6C2PNG2LPO3RI3BQRANCNFSM4LOYHVXA>.
On Mar. 22, 2020 10:20 p.m., Kyle Venn <[email protected]> wrote:
Oh nice! @titaniumbones<https://github.com/titaniumbones> so is your fork actively being updated with real information?
I'd love to point at https://titaniumbones.github.io/covid19/timeseries.json it if you're going to keep it up!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#13 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AACY6NHVMUUY6C2PNG2LPO3RI3BQRANCNFSM4LOYHVXA>.
|
I'm going to close this one, we won't add province/state support |
buildSeries
to extract main parsing logicprovince-${country}.json
for the relevantcountries
Addresses half of #9