Upgrade react-application-breadcrumb to SPFx v1.20.0 #1419
+26,252
−20,964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-daly
changed the title
tom-daly
changed the title
add back the samples file
|
Thank you for opening a PR to our samples repo and helping us upgrade our project 👍 |
remove windows build file
Adam-it
requested changes
Oct 11, 2024
| @@ -2,7 +2,7 @@ declare interface ISiteBreadcrumbStrings { | |||
| Title: string; | |||
| } | |||
|
|
|||
| declare module 'siteBreadcrumbStrings' { | |||
| declare module 'SiteBreadcrumbApplicationCustomizerStrings' { | |||
There was a problem hiding this comment.
Unfortunately, after this change we should also update config/config.json and change the localizedResources to the new name as well
currently without this change if I run the gulp bundle --ship it will crash
There was a problem hiding this comment.
Not sure how that happened because I installed it and tested it. I've just put the name back to the original, checked the build and deployed it out to my test site to ensure it was still working. I cleared everything out and re-added it to ensure it was fresh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?