Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade sp dependencies and remove lit file transformation #25

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

musale
Copy link
Contributor

@musale musale commented Oct 17, 2024

By submitting this pull request, you agree to the contribution guidelines

If you aren't familiar with how to contribute to open-source repositories using GitHub, or if you find the instructions on this page confusing, sign up for one of our Sharing is Caring events. It's completely free, and we'll guide you through the process.

Q A
Bug fix? yes
New feature? no
New sample? no
Related issues? fixes #23 , fixes #24 and fixes #21

What's in this Pull Request?

  • Updated the sharepoint packages to 1.20+. This essentially updates webpack to version 5.88.2 which means, the transformer code in the gulpfile is no longer needed.

@musale musale mentioned this pull request Oct 17, 2024
9 tasks
@musale
Copy link
Contributor Author

musale commented Oct 17, 2024

@sebastienlevert @gavinbarron please review.

@gavinbarron
Copy link
Collaborator

Nice work @musale

Can you please upgrade the relevant .yo-rc.json files. I've found the best way to do this is to use the generator to bootstrap a new project to get the correct version and sdkVersions.

@musale
Copy link
Contributor Author

musale commented Oct 17, 2024

@gavinbarron updated both instances.

@gavinbarron gavinbarron merged commit a47d559 into pnp:main Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the sp-mgt sample Update the sp-webpart sample Error serving up sp-webpart sample
2 participants