Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix site setup access at toolbar by using @actions endpoint. #6413

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Faakhir30
Copy link
Contributor

@Faakhir30 Faakhir30 commented Oct 17, 2024


If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #6355

Avoiding calling Actions get API again by passing through the parent component, as the toolbar already has access to actions.

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit bfa4841
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/67123a5c246435000842e443

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sprinkle a little MyST syntax for the change log. Otherwise LGTM, but needs a technical review.

packages/volto/news/6355.bugfix Outdated Show resolved Hide resolved
Copy link
Member

@JeffersonBledsoe JeffersonBledsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test over the weekend, but the code seems fine apart from using lodash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PersonalTools/ Site Setup assumes Site Administrators have the correct permission for the site setup action
3 participants