Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows versioning of the Plone Site type for the portal working copy to work #113

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allows versioning of the Plone Site type for the portal working copy to work #113

wants to merge 3 commits into from

Commits on Oct 2, 2024

  1. Allows versioning of the "Plone Site" type 

    For the working copy of plone.app.iterate to work on the "Plone Site"
type, it is necessary that this type is versionable. See:

https://github.com/plone/plone.app.iterate/blob/1908aa1f4e9c95c37143fae88655469b72ea451a/plone/app/iterate/browser/control.py#L88-L90
    @wesleybl
    wesleybl committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    9e6990e View commit details
    Browse the repository at this point in the history

  2. Allows the "Plone Site" type to be cloned 

    Products.CMFEditions uses the pickle module to clone objects. See:

https://github.com/plone/Products.CMFEditions/blob/c80bc31af46bff45fee2908878b1f01190fda8d8/Products/CMFEditions/ArchivistTool.py#L210-L229

These changes prevent the error:

TypeError: Can't pickle objects in acquisition wrappers

When trying to serialize an ImplicitAcquisitionWrapper object with the
pickle dump. This error occurred when trying to check in a Plone Site
type with plone.app.iterate.

These changes also allow the Plone Site type to be serialized with the
pickle.
    @wesleybl
    wesleybl committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    b085aec View commit details
    Browse the repository at this point in the history

  3. Add changes

    @wesleybl
    wesleybl committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    965e383 View commit details
    Browse the repository at this point in the history