Use Magento 2.4

[tylers-username]

Description (*)

Upgrade template to Magento 2.4 with Elasticsearch 7.7 and Composer 2

Fixed Issues (if relevant)

1. Are there any plans on updating Magento, PHP and Composer versions? #15

Manual testing scenarios (*)

1. Create project from template
2. Confirm that searches do not return and error
3. Confirm that admin password is prompted for reset after first login
4. Confirm there are no deployment errors

Questions or comments

On Lando Development

This is 99% Lando compatible. The only issue is that after lando start you must lando restart before the Elasticsearch is exposed to the app. This is a Lando issue, not a Magento or template issue.

This also means that if you are using Lando for local development, you'll need to manually lando ssh -c "php deploy.php" for the Magento setup to run locally.

PR Commits
Lots of files are changed in this PR. Sorry, they're not squashed. Here's what to expect:

1. Tons of Magento 2.4 files merged into this PR.
2. Refactor python deploy script to php #22 is merged into this PR.
3. A number of commits testing deployments with a new patch added to the deploy.php that resolves a Magento setup:install bug.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[tylers-username]

Just reviewed this MR and hit some strange merge conflicts when testing merging into main. If git merge feature/magento2.4 -x theirs is unacceptable, then let me know if I need to create a new MR with a friendlier merge ready to go.

[gilzow]

Interestingly, I checked the PR environment, and it's throwing an error.

Fatal error: Class Magento\Framework\Session\Config\ConfigInterface\Proxy contains 2 abstract methods and must therefore be declared abstract or implement the remaining methods (Magento\Framework\Session\Config\ConfigInterface::setCookieSameSite, Magento\Framework\Session\Config\ConfigInterface::getCookieSameSite) in /app/generated/code/Magento/Framework/Session/Config/ConfigInterface/Proxy.php on line 7

Checked the deploy log and it shows it failed to install:

[Progress: 4 / 874]
Installing database schema:

In AbstractFactory.php line 131:

  Type Error occurred when creating object: Magento\Catalog\Model\CategoryRep
  ository\Interceptor, Too few arguments to function Magento\Catalog\Model\Ca
  tegoryRepository::__construct(), 3 passed in /app/generated/code/Magento/Ca
  talog/Model/CategoryRepository/Interceptor.php on line 14 and exactly 4 exp
  ected

<snip>

Build failed w/ command: php bin/magento setup:install --ansi --no-interaction --skip-db-validation --base-url=https://pr-24-pynalzq-ckm4bz3mukihi.eu-3.platformsh.site/ <etc>

Tried redeploying, same error.

[tylers-username]

This is likely due to the PR environment starting out as 2.3 rather than a blank project. Special steps would need to be taken to upgrade from 2.3 to 2.4.

To test this PR you'd want to start with a blank environment.

[danharper83]

I'm looking to upgrade to 2.4, is this ticket still active?

[rfay]

It's really important to get this done. Current is Magento 2.3.7, which went out of support a year ago

Support for the 2.3 release line ended on September 8, 2022.