Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): fix distorted RNNoise output during mono capture #400

Merged
merged 1 commit into from
May 11, 2024

Conversation

codeHusky
Copy link
Contributor

Fix sourced from remjey/mumble@f16b47c

When the input signal is very loud and clipping, the output of RNNoise is very distorted, way more than the input signal.

This is because RNNoise outputs a signal that is unbounded and sometimes goes over the limits of the signed 16-bit signal that Mumble uses internally. When Mumble converts RNNoise output signal to 16-bit, integer overflow occurs and creates a very loud distortion.

Mumble now clamps the output of RNNoise which results in a signal that is not more distorted than the input signal.

This code clamps the values sent to RNNoise to prevent loud overdrive clipping, fixing #370

@Apehum Apehum merged commit 54f84a2 into plasmoapp:v2.0.x May 11, 2024
Apehum pushed a commit that referenced this pull request May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants