Skip to content

Commit

Permalink
Fix leftover from #825 (#844)
Browse files Browse the repository at this point in the history
* Fix leftover from #825

* Remove pip install -U pip calls
  • Loading branch information
ddelange authored Oct 30, 2024
1 parent 60976d0 commit 283e93a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 23 deletions.
15 changes: 0 additions & 15 deletions .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ jobs:
with:
python-version: "3.11"

- name: Update pip
run: pip install -U pip

- name: Install dependencies
run: pip install flake8

Expand Down Expand Up @@ -47,9 +44,6 @@ jobs:
with:
python-version: ${{ matrix.python-version }}

- name: Update pip
run: pip install -U pip

- name: Install smart_open without dependencies
run: pip install -e .

Expand Down Expand Up @@ -90,9 +84,6 @@ jobs:
with:
python-version: ${{ matrix.python-version }}

- name: Update pip
run: pip install -U pip

- name: Install smart_open and its dependencies
run: pip install -e .[test]

Expand Down Expand Up @@ -128,9 +119,6 @@ jobs:
with:
python-version: ${{ matrix.python-version }}

- name: Update pip
run: pip install -U pip

- name: Install smart_open and its dependencies
run: pip install -e .[test]

Expand Down Expand Up @@ -178,9 +166,6 @@ jobs:
with:
python-version: ${{ matrix.python-version }}

- name: Update pip
run: pip install -U pip

- name: Install smart_open and its dependencies
run: pip install -e .[test]

Expand Down
9 changes: 1 addition & 8 deletions smart_open/http.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,14 +122,7 @@ def __init__(self, url, mode='r', buffer_size=DEFAULT_BUFFER_SIZE,

self.timeout = timeout

self.response = session.get(
url,
auth=auth,
cert=cert,
stream=True,
headers=self.headers,
timeout=self.timeout,
) if session is not None else requests.get(
self.response = self.session.get(
url,
auth=auth,
cert=cert,
Expand Down

0 comments on commit 283e93a

Please sign in to comment.