system input frames and audio buffer processor fixes #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Input frames from a transport should be processed fast and there's no need for them to be queued internally in each element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
This PR changes current input frames to be system frames. System frames are not queued internally by processors. This allows processing input frames (audio, video or transport messages) as quickly as they arrive (which is a good thing).
And since the input frames are not queued, it also allows for interruptions to work in
AudioBufferProcessor(or others). What was happening is that input frames were being queued in processors through the pipeline so it was possible that when an interruption occurred those input audio frames were still in some part of the pipeline not making it all the way to theAudioBufferProcessor.