adding session_timeout param #742
Open
+41
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Vaibhav-Lodha, thanks for the PR! In general, I agree with this type of addition. The one thing I'd like to talk over with the team is related to this issue: #728. The websocket connection will be severed but the call will be ongoing. @aconchillo has worked on this but he's out for a family emergency. Once he's back, we'll discuss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
Implementing a
session_timeoutevent for FastAPI and Websocket transport will grant users control over the pipeline. This event will be triggered when the time limit reaches a predefined threshold. Upon receiving this event, the pipeline will be gracefully terminated, adhering to the user’s business requirements. For instance, calls routed through Twilio can be terminated after a maximum of two minutes.