Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run some workflows only in pimcore repos #606

Draft
wants to merge 8 commits into
base: 1.6
Choose a base branch
from

Conversation

herbertroth
Copy link
Member

No description provided.

@herbertroth herbertroth changed the base branch from 1.x to 1.5 July 8, 2024 09:36
@blankse
Copy link
Contributor

blankse commented Jul 8, 2024

@herbertroth Do this work with PRs from forks?

@herbertroth
Copy link
Member Author

@blankse This disables CS Fixer runs on PRs from forks. It’s simply not possible to do this on PRs for forks. This would require a way to get write permissions on the forked repo with a token stored at Pimcore. For very good reasons, this can’t work. So the CS Fixer will only run for PRs for a Pimcore-owned repo to avoid error messages indicating that a token is not present.

@blankse
Copy link
Contributor

blankse commented Jul 8, 2024

@herbertroth But with the pull_request_target it was working with PRs from forks.

For example see here: pimcore/pimcore#17012
This PR is from my fork and the php-cs-fixer did make changes.

@herbertroth
Copy link
Member Author

@blankse This PR solves a different problem. If you fork this to E.G.: blankse/pimcore and than do a PR to blankse/pimcore this will run and try to find a key stored at pimcore. The key will not be present and will trigger an error. If you do a PR from blankse/pimcore to pimcore/pimcore this will work.

@blankse
Copy link
Contributor

blankse commented Jul 8, 2024

@herbertroth Yes, with pull_request_target it should work :)

@herbertroth
Copy link
Member Author

@blankse I would be happy if we could test this together after the merge. It’s tricky to do this alone.

@herbertroth herbertroth marked this pull request as draft July 8, 2024 12:09
@herbertroth herbertroth changed the title Run php cs fixer only in pimcore repos Run some workflows only in pimcore repos Jul 8, 2024
Copy link

sonarcloud bot commented Jul 10, 2024

Copy link

sonarcloud bot commented Sep 13, 2024

@kingjia90 kingjia90 changed the base branch from 1.5 to 1.6 October 1, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants