Bugfix to read more than 100 files inside an uploaded folder #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix to read more than 100 files inside an uploaded folder
|
Hi @mschweiger90 since this is a bugfix could you please change the base branch to 1.4 and use |
|
|
@robertSt7 I was able to change the base branch to 1.5 and changed to const and let. You can ignore the sonarcloud warnings and the files changed because of the CS fixer |
|
Looks like some Chrome limitation Is it limited to Chrome v77? Could you please share your current browser version where you encountered this issue? So the PR looks LGTM on paper, i will give it a try to see if they changed it later on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you upload an asset folder with more than 100 files inside directly in pimcore, only 100 files are saved!