Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value input fields for Multiselect #252

Open
wants to merge 7 commits into
base: 1.x
Choose a base branch
from

Conversation

jan888adams
Copy link

@jan888adams jan888adams commented Aug 31, 2023

Add input fields for default value and default value generator for Multiselect Object type.

I already have an MR open for the backend part.

@jan888adams jan888adams changed the title add default value and default value generator input fields [Task] add default value and default value generator input fields Aug 31, 2023
@jan888adams jan888adams changed the title [Task] add default value and default value generator input fields Default value and default value generator input fields Aug 31, 2023
@jan888adams jan888adams changed the title Default value and default value generator input fields Default value input fields for Multiselect Sep 1, 2023
@jan888adams jan888adams marked this pull request as draft September 6, 2023 16:20
@dvesh3 dvesh3 added this to the 1.3.0 milestone Oct 12, 2023
@jan888adams jan888adams force-pushed the task/default-value-for-multi-select-type branch from 519471b to 6421f6a Compare October 30, 2023 18:11
@jan888adams jan888adams marked this pull request as ready for review October 30, 2023 18:16
@robertSt7
Copy link
Contributor

Hi @jan888adams could you please use let and const instead of var for variables in JavaScript? Thanks

@dvesh3 dvesh3 removed this from the 1.3.0 milestone Nov 14, 2023
@robertSt7 robertSt7 self-assigned this Apr 19, 2024
@robertSt7
Copy link
Contributor

Hi @jan888adams I get the following errors, when I start pimcore and try to open a class which contains a Select and Multiselect field.
image
Could you please take a look at this? Thx :)

Copy link

sonarcloud bot commented Aug 29, 2024

@mattamon
Copy link
Contributor

Hi @jan888adams I get the following errors, when I start pimcore and try to open a class which contains a Select and Multiselect field. image Could you please take a look at this? Thx :)

I merged the latest 1.x changes into the branch and fixed the class.js error.
Should be good to go now for another review.

@mattamon
Copy link
Contributor

mattamon commented Sep 9, 2024

@jan888adams can you please recheck this PR. When I add a new multiselect to a class I get the following error:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants