Implement SocketCreateReturnTypeExtension #3667
Open
+78
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
force-pushed
the
socket_create
branch
2 times, most recently
from
48a48c8
to
16ba677
Compare
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Nov 26, 2024
src/Php/PhpVersions.php
Outdated
| @@ -28,4 +28,9 @@ public function producesWarningForFinalPrivateMethods(): TrinaryLogic | |||
| return IntegerRangeType::fromInterval(80000, null)->isSuperTypeOf($this->phpVersions)->result; | |||
| } | |||
|
|
|||
| public function socketCreateUsesResource(): TrinaryLogic | |||
| { | |||
| return IntegerRangeType::fromInterval(null, 79999)->isSuperTypeOf($this->phpVersions)->result; | |||
There was a problem hiding this comment.
I'd write this as "since 8.0" rather than until "7.9999". So rename this method to what it actually returns since 8.0.
|
broken build is unrelated |
staabm
force-pushed
the
socket_create
branch
from
be7173c
to
5fbfc32
Compare
|
just found https://php.watch/versions/8.0/sockets-sockets-addressinfo which describes all functions which have been changed from |
staabm
force-pushed
the
socket_create
branch
from
b0ccacc
to
48543d1
Compare
|
This pull request has been marked as ready for review. |
staabm
force-pushed
the
socket_create
branch
from
48543d1
to
1ef8b62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php-version dependent
socket_createhandling to ease writing cross php version coderefs phpstan/phpstan#4212
see https://php.watch/versions/8.0/sockets-sockets-addressinfo