hpcc: Improve multi-arch installation
#279
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LA toolchain variable configuration has been updated to be CPU architecture-independent.
All hard-coded architecture-dependent paths have been revised to use PTS' `OS_ARCH` variable when searching for—as well as configuring—toolchain variables.
- If either an MPI or Linear Algebra (LA) toolchain can **not** be found, then `hpcc` can **not** be built. - Error codes have been defined to assist users in understanding why the install script failed.
- Avoid any potential collisions with other _error identifiers_. - Script-specific _error identifier_ is written to `install-exit-status`.
….0.1` downloads to reflect new GitHub repo name". This reverts commit dba209a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @michaellarabel:
While running
hpcc-1.2.8on an Apple M1 Pro, the installation script couldn't find an installed Linear Algebra (LA) library—that's supported by HPCC—to pass to the linker for AArch64 platforms—even though an HPCC supported LA library was available.This pull request improves multi-arch
hpcctest installation by:OS_ARCHvariable duringhpcc's install-phase on supported Linux distros—i.e., Debian, Ubuntu, and Red Hat;hpccis not found;install-exit-status; anddebug-install.Please review and consider adding these improvements to the install script for
hpcc.Sincerely,
Tad