-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update firecrawl tool with additional features #1445
base: main
Are you sure you want to change the base?
Conversation
@manthanguptaa any updates on this ? |
cookbook/tools/firecrawl_tools.py
Outdated
reasoning=True, | ||
markdown=True, | ||
) | ||
agent.print_response(f"Crawl and analyze the main use cases and insights using asynchronous crawling: {url}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra whitespace in the middle of the sentence
cookbook/tools/firecrawl_tools.py
Outdated
|
||
|
||
if __name__ == "__main__": | ||
url = "https://www.firecrawl.dev/blog" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace the link with https://docs.phidata.com/agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you not have Agents in functions and then call them? I think you can have only 1 Agent with the following config
Agent(
tools=[FirecrawlTools(scrape=True, crawl=True, async_crawl=True, limit=25)],
show_tool_calls=True,
reasoning=True,
markdown=True,
)
and then ask the agent to do it synchronously or asynchronously
cookbook/tools/firecrawl_tools.py
Outdated
) | ||
agent.print_response(f"Fetch all the blog links from the website: {url}") | ||
agent.print_response( | ||
"scrape and summarize the following website: https://www.firecrawl.dev/blog/using-structured-output-and-json-strict-mode-openai" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace this link with https://docs.phidata.com/workflows
if async_crawl: | ||
self.register(self.async_crawl_website) | ||
if crawl or async_crawl: | ||
self.register(self.check_crawl_status) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be here? What if only async_crawl is True
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if only async_crawl
is True then also the code block will execute @manthanguptaa
@manthanguptaa did u encounter it while running the cookbook script ? |
Async Crawling
andMap
functionality. #1349cc: @manthanguptaa