Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list_state_counterparts.rq #5

Merged
merged 2 commits into from
Nov 20, 2019
Merged

Update list_state_counterparts.rq #5

merged 2 commits into from
Nov 20, 2019

Conversation

balhoff
Copy link
Member

@balhoff balhoff commented Nov 26, 2018

Addresses part of #2.

# replace the value of the following prefix with the character URI of interest
# Replace the value of the following prefix with the character URI of interest
# These URIs are not persistent across KB updates; this example will return no
# results unless you provide a valid character URI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for #7 -- is it feasible to simply sample (first or last, or something) from character URIs in the database?

Again, this would only make sense if the assumption holds that there are no character URIs in the database that wouldn't produce a row in this query's result.

@hlapp
Copy link
Member

hlapp commented Nov 20, 2019

Works now. BTW it doesn't seem the character is selected randomly – it seems to the same one every time.

@hlapp hlapp merged commit 5392f84 into master Nov 20, 2019
@hlapp hlapp deleted the balhoff-patch-1 branch November 20, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants