Fix variable values thread safety in pure mode #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test currently fails because the value of the "var" variable" set by one thread is overwritten by the other thread. Theoretically this test would fail or not depending on how the 2 threads are executed and interweaved. But it seems to always fail, so no further complication is added for now.
To ensure that variable values are not overwritten when different XML are validated on separate threads, store the variable values in aborts ThreadLocal map. Fixes issue phax#182.
|
@phax : Any chance you could have a look at this PR ? |
|
I will try to understand and crosscheck during the week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #182 by storing variable values in a ThreadLocal map, and add a unit test to check for this.
This might not be a perfect fix, but it seems to do the trick.
After this change, the compiled XPaths for the variable values are still potentially used from multiple threads, and XPathExpression is indicated as not being thread-safe.
But I did not see any easy way to adress this, and this does not seem to cause any problems.