chore(deps): Upgrade java from 11 to 17 #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericenns
added
dependencies
ericenns
force-pushed
the
dependencies/java-17
branch
from
561422a to
5520627
Compare
…um due to OS bit changing from 0 to 255 in java 16 and 17.
ericenns
force-pushed
the
dependencies/java-17
branch
from
5520627 to
c1995cd
Compare
deepsidhu85
approved these changes
Nov 20, 2024
apetkau
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Everything looks great to me.
Tested on my own machine (Ubuntu 22.04.5) using Java 17 (installed using apt) and Tomcat9 (installed via apt).
I had to configure the sequence-files/output-files, etc directories to be writable by tomcat9 (as in this issue: #1555).
Tested with previously built IRIDA plugins (built prior to switch to Java 17) and they all work. Specifically the plugins:
- amr-detection
- species-abundance
- sistr
These run the pipelines and write the proper metadata into the IRIDA metadata table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
What did you change in this pull request? Provide a description of files changed, user interactions changed, etc. Include how to test your changes.
Related issue
Link to the GitHub issue this pull request addresses using the
#issuenumformat. If it completes an issue, useFixes #issuenumto automatically close the issue.Checklist
Things for the developer to confirm they've done before the PR should be accepted: