Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Project Samples Test #869

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ChrisHuynh333
Copy link
Collaborator

@ChrisHuynh333 ChrisHuynh333 commented Dec 12, 2024

What does this PR do and why?

This PR refactors system/projects/samples_test.rb.

Upon revision, there were many aspects of the testing file that needed cleanup and/or fixing.
This is including but not limited to:

  1. Ensuring assertions are actually testing what the test title states
  2. Removing redundancies between tests (eg: no need to check for a header every time we visit a page unless we're testing a redirect).
  3. Split larger tests into multiple tests so tests are shorter and more focused.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

  1. Verify tests pass locally

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Copy link

Code Metrics Report

Coverage Test Execution Time
92.7% 9m33s

Reported by octocov

@ChrisHuynh333 ChrisHuynh333 force-pushed the refactor/project-samples-test branch from 077c5b8 to b039ec1 Compare December 13, 2024 15:33
@ChrisHuynh333 ChrisHuynh333 force-pushed the refactor/project-samples-test branch from 633507f to cc32437 Compare December 13, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant