Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Table Bot Accounts: Remove PAT panel on destroy #860

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

ChrisHuynh333
Copy link
Collaborator

@ChrisHuynh333 ChrisHuynh333 commented Dec 3, 2024

What does this PR do and why?

This PR is a followup to #849, and adds logic to remove the new PAT frame upon bot deletion or revoked PAT. This is because we wouldn't want the new PAT panel to persist upon the potential removal of the PAT itself or its associated bot. Due to the changes in response logic in #849, the PAT frame now uses data-turbo-permanent attribute to persist through response refreshes, and requires explicit logic to remove/hide it.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

Repeat for both project and group bots:

  1. Navigate to the bot accounts page
  2. Create a new bot or generate a new token for an existing bot. Afterwards, the new PAT frame should render.
  3. Delete a bot. The new PAT frame should no longer appear.
  4. Repeat step 2, and afterwards, revoke a PAT from a bot. Once again, the new PAT frame should no longer appear.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant