-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New project subgroup/searchable dropdown #837
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
637c191
to
98b192c
Compare
Code Metrics Report
Code coverage of files in pull request scope (100.0%)
Reported by octocov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just took a quick look through this. My one major comment I have is that if I were a user and I clicked "Create project" from within a group, I would expect that the namespace would auto-populate to be that namespace and I would not need to search for it, possibly even disable changing it.
{}, | ||
{ class: "prefixed" }, | ||
) %> | ||
<div class="flex-1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking through LookBook, I actually created a viral component that you can use to do exactly this http://localhost:3000/rails/lookbook/inspect/viral_form_prefixed_select/default
What does this PR do and why?
Describe in detail what your merge request does and why.
This PR adds the searchable dropdown to the new Project and new Subgroup forms. This dropdown will make it easier for a user to look up a specific Namespace or Group when creating a new Project or Subgroup.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.