Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New project subgroup/searchable dropdown #837

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

malchua
Copy link
Contributor

@malchua malchua commented Nov 6, 2024

What does this PR do and why?

Describe in detail what your merge request does and why.
This PR adds the searchable dropdown to the new Project and new Subgroup forms. This dropdown will make it easier for a user to look up a specific Namespace or Group when creating a new Project or Subgroup.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.
image
image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Login
  2. In the sidebar, click on Groups
  3. Select a group that your are an owner of
  4. On the details page, click on the New project button
  5. In the Project URL, search for any Namespaces that you have at least the Maintainer role for and check that they present on the list.
  6. Repeat steps 1-5 with the New subgroup button and Group URL section.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

This comment has been minimized.

@malchua malchua marked this pull request as ready for review November 8, 2024 19:34
@malchua malchua force-pushed the new-project-subgroup/searchable-dropdown branch from 637c191 to 98b192c Compare November 12, 2024 22:22
Copy link

Code Metrics Report

Coverage Test Execution Time
93.3% 8m48s

Code coverage of files in pull request scope (100.0%)

Files Coverage
app/views/groups/_form_fields.html.erb 100.0%
app/views/groups/new_subgroup.html.erb 100.0%
app/views/projects/_project_namespace_fields.erb 100.0%
app/views/projects/new.html.erb 100.0%

Reported by octocov

@ericenns ericenns requested a review from joshsadam November 22, 2024 18:24
Copy link
Contributor

@joshsadam joshsadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just took a quick look through this. My one major comment I have is that if I were a user and I clicked "Create project" from within a group, I would expect that the namespace would auto-populate to be that namespace and I would not need to search for it, possibly even disable changing it.

{},
{ class: "prefixed" },
) %>
<div class="flex-1">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Can you see if there is a way that you can get the left corners of the select to be 90 degrees so they stay inline with the root URL corners:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking through LookBook, I actually created a viral component that you can use to do exactly this http://localhost:3000/rails/lookbook/inspect/viral_form_prefixed_select/default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants