Trying bytea->pcpoint conversion #212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: The-Alchemist <[email protected]>
elemoine
reviewed
Jun 14, 2018
| @@ -186,6 +186,10 @@ CREATE OR REPLACE FUNCTION pcpoint_in(cstring) | |||
| RETURNS pcpoint AS 'MODULE_PATHNAME', 'pcpoint_in' | |||
| LANGUAGE 'c' IMMUTABLE STRICT; | |||
|
|
|||
| CREATE OR REPLACE FUNCTION pcpoint_in(bytea) | |||
There was a problem hiding this comment.
I wouldn't name this function pcpoint_in. pcpoint_in and pcpoint_out are the pcpoint type's input and output functions, respectively. So I'd rather not add a pcpoint_in function that doesn't participate to the type definition.
So I suggest that we name this function PC_PointFromWKB, which is consistent with PostGIS' ST_GeomFromWKB function.
|
See my comment above regarding the function name. Also, if we add this function and cast for points, I think we should do the same for patches. We'd also need to add docs and tests. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following patch enables code like:
Feedback requested.
I was hoping to take advantage of new bytea->pcpoint function as the
receive_function, but I'm not quite sure how that works or if I did it right. Any tips suggested. :)