Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(C++) adding missing include to be fully compatible with C++13 #2663

Merged

Conversation

cvvergara
Copy link
Member

Fixes #2639 .

Changes proposed in this pull request:

  • add missing include

@pgRouting/admins

@cvvergara cvvergara added this to the Release 3.6.3 milestone Oct 12, 2024
@cvvergara cvvergara requested a review from robe2 October 12, 2024 16:28
@cvvergara
Copy link
Member Author

The clang tidy error is because the file extension is h instead of hpp.
Lots if headers have the same problem.

Copy link
Member

@robe2 robe2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only a little surprised result outputs of pgr_storerWagner changes. Is that not deterministic?

@cvvergara cvvergara merged commit 4dc2813 into pgRouting:main Oct 12, 2024
24 checks passed
@cvvergara
Copy link
Member Author

Yes it is, but the boost version fixed a bug on that algorithm so, and because CI now uses that new version, well, changing the result. (actually is a change I forgot to do in the other PR its already documented on the news)

@cvvergara cvvergara deleted the issue-2639-Missing-GCC-13+-compatibility branch October 12, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing GCC 13+ compatibility
2 participants