feat: add MIN_ULID and MAX_ULID constants #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perry-mitchell
approved these changes
Oct 8, 2023
|
Looks good! Thanks for this. It'll go out tonight. |
|
Good to note here, however, that using these in a range is not entirely sufficient in testing validity. The If 100% confidence isn't necessary (quick validation or comparison) then this would otherwise be acceptable imo. |
|
@perry-mitchell Thanks! |
|
@perry-mitchell Will you release a new version soon? |
|
Released 2.2.0 just now @bradvogel :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exports new constants
MIN_ULIDandMAX_ULID. These can be useful when doing range queries to look for valid ULIDs, egNote: this was also submitted as a PR to the official, yet unmaintained, repo: ulid/javascript#107