draft: add tsup #104
Open
draft: add tsup #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately it turns out my previous PR doesn't fix ESM support.
This is because the node ESM resolver requires imports to include file extensions.
Now there are 2 ways to do this.
Use a bundler like tsup, this will automatically add missing file extensions to the build output. Downside is that tsup bundles everything into a single js file. This might be a breaking change because consumers can be importing from permitio/(main/module)/*
Add .js extension to all imports manually in the source code. A bit more involved, but you can keep using tsc to build the package. The .mjs rename script does need to get updated to also rename all .js imports to .mjs. This will be quite a bit more work.
This PR adds tsup to build the package so you can explore this option.
Also noticed the package still depends on node 14 types, this version has been end of life for a long time. 23 is current.
See: https://nodejs.org/en/about/previous-releases