Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add vitest as test tool and increase test coverage #23

Closed
wants to merge 2 commits into from

Conversation

varshith257
Copy link

@varshith257 varshith257 commented Oct 29, 2024

Closes #12
/claim #12

Test coverage increased to 85%. The coverage is majorly left out in the Login.tsx and Policy.tsx. There are errors in the flows of this files and needed fixes which I count as the out of scope of this bounty.

@varshith257
Copy link
Author

@quest-bot loot #12

@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Oct 29, 2024
Copy link

quest-bot bot commented Oct 29, 2024

Quest PR submitted! image Quest PR submitted!

@varshith257, you are attempting to solve the issue and loot this Quest. Will you be successful?


Questions? Check out the docs.

@varshith257
Copy link
Author

Just couple of issues in login and logout tests. Fixing them

@gemanor
Copy link
Collaborator

gemanor commented Nov 3, 2024

Hey, why do you need to change the source to src? Is that automated cursor refactoring or something?

@varshith257
Copy link
Author

varshith257 commented Nov 4, 2024

@gemanor Yes! It has been renamed to simplify long dir name and to follow simplier standard name

@gemanor
Copy link
Collaborator

gemanor commented Nov 7, 2024

@varshith257 we don't need this renaming, please revert and keep the code as is. The issue was to add text, not to rename folders.

@gemanor
Copy link
Collaborator

gemanor commented Nov 7, 2024

Is that maybe something made automatically by AI tools like cursor?

@varshith257
Copy link
Author

@gemanor No! I have renamed it

@varshith257
Copy link
Author

varshith257 commented Nov 18, 2024

@gemanor Can you have a look at this PR?

@varshith257
Copy link
Author

@gemanor Is this PR reviews blocked with source folder renaming?

@gemanor
Copy link
Collaborator

gemanor commented Nov 20, 2024

Hey @varshith257, I asked explicitly not to change anything in the project but to add tests with a coverage report. I don't see how your giant PR addresses this. Reviewing such PRs disrupt my focus, and I can't handle it. Closing it for now, you can open a new one if you'd like with the code that addresses the requirements we asked for.

@gemanor gemanor closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim ⚔️ Quest Tracks quest-bot quests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Proper Unit Test Coverage
2 participants