-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add vitest as test tool and increase test coverage #23
Conversation
@quest-bot loot #12 |
Quest PR submitted!@varshith257, you are attempting to solve the issue and loot this Quest. Will you be successful? Questions? Check out the docs. |
Just couple of issues in login and logout tests. Fixing them |
Hey, why do you need to change the source to src? Is that automated cursor refactoring or something? |
@gemanor Yes! It has been renamed to simplify long dir name and to follow simplier standard name |
@varshith257 we don't need this renaming, please revert and keep the code as is. The issue was to add text, not to rename folders. |
Is that maybe something made automatically by AI tools like cursor? |
@gemanor No! I have renamed it |
@gemanor Can you have a look at this PR? |
@gemanor Is this PR reviews blocked with source folder renaming? |
Hey @varshith257, I asked explicitly not to change anything in the project but to add tests with a coverage report. I don't see how your giant PR addresses this. Reviewing such PRs disrupt my focus, and I can't handle it. Closing it for now, you can open a new one if you'd like with the code that addresses the requirements we asked for. |
Closes #12
/claim #12
Test coverage increased to 85%. The coverage is majorly left out in the Login.tsx and Policy.tsx. There are errors in the flows of this files and needed fixes which I count as the out of scope of this bounty.