Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record with pointer receivers only #8

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Record with pointer receivers only #8

merged 2 commits into from
Jan 26, 2024

Conversation

pellared
Copy link
Owner

@pellared pellared commented Jan 25, 2024 •
edited
Loading

Per open-telemetry#4809 (comment)

On go version go1.21.4 linux/amd64:

goos: linux
goarch: amd64
pkg: go.opentelemetry.io/otel/log/internal
cpu: Intel(R) Core(TM) i9-10885H CPU @ 2.40GHz
                        │    old.txt    │                new.txt                │
                        │    sec/op     │    sec/op      vs base                │
Emit/noop/no_attrs-16      3.170n ± 10%    3.785n ±  5%  +19.44% (p=0.000 n=10)
Emit/noop/3_attrs-16       7.776n ±  6%   13.130n ± 15%  +68.84% (p=0.000 n=10)
Emit/noop/5_attrs-16       10.07n ±  9%    15.96n ±  7%  +58.62% (p=0.000 n=10)
Emit/noop/10_attrs-16      134.0n ±  7%    147.0n ± 17%   +9.74% (p=0.000 n=10)
Emit/noop/40_attrs-16      574.0n ±  9%    698.2n ±  5%  +21.64% (p=0.000 n=10)
Emit/writer/no_attrs-16    57.01n ±  2%    56.17n ±  9%        ~ (p=0.529 n=10)
Emit/writer/3_attrs-16     145.3n ±  3%    156.0n ± 19%        ~ (p=0.138 n=10)
Emit/writer/5_attrs-16     184.8n ±  6%    150.6n ±  2%  -18.48% (p=0.000 n=10)
Emit/writer/10_attrs-16    482.2n ±  5%    385.1n ±  3%  -20.16% (p=0.000 n=10)
Emit/writer/40_attrs-16    3.104µ ± 30%    1.704µ ±  4%  -45.12% (p=0.000 n=10)
Slog/no_attrs-16          151.65n ±  8%    92.76n ±  2%  -38.83% (p=0.000 n=10)
Slog/3_attrs-16            187.6n ±  3%    134.2n ±  3%  -28.46% (p=0.000 n=10)
Slog/5_attrs-16            227.9n ±  6%    167.4n ±  4%  -26.52% (p=0.000 n=10)
Slog/10_attrs-16          1003.1n ±  8%    812.4n ±  7%  -19.01% (p=0.001 n=10)
Slog/40_attrs-16           4.815µ ± 10%    6.634µ ± 15%  +37.79% (p=0.000 n=10)
Logr/no_attrs-16           6.296n ±  9%    7.549n ± 20%  +19.89% (p=0.000 n=10)
Logr/3_attrs-16            118.3n ±  7%    140.3n ± 19%  +18.60% (p=0.000 n=10)
Logr/5_attrs-16            193.8n ±  4%    218.7n ±  2%  +12.82% (p=0.000 n=10)
Logr/10_attrs-16           804.2n ±  8%    867.6n ±  7%   +7.88% (p=0.009 n=10)
Logr/40_attrs-16           5.085µ ±  3%    5.093µ ±  6%        ~ (p=1.000 n=10)
geomean                    175.9n          176.0n         +0.01%

                        │    old.txt     │                new.txt                │
                        │      B/op      │     B/op      vs base                 │
Emit/noop/no_attrs-16       0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/noop/3_attrs-16        0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/noop/5_attrs-16        0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/noop/10_attrs-16       208.0 ± 0%       208.0 ± 0%       ~ (p=1.000 n=10) ¹
Emit/noop/40_attrs-16     1.375Ki ± 0%     1.375Ki ± 0%       ~ (p=1.000 n=10) ¹
Emit/writer/no_attrs-16     16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=10) ¹
Emit/writer/3_attrs-16      48.00 ± 0%       48.00 ± 0%       ~ (p=1.000 n=10) ¹
Emit/writer/5_attrs-16      48.00 ± 0%       48.00 ± 0%       ~ (p=1.000 n=10) ¹
Emit/writer/10_attrs-16     296.0 ± 0%       296.0 ± 0%       ~ (p=1.000 n=10) ¹
Emit/writer/40_attrs-16   1.695Ki ± 0%     1.695Ki ± 0%       ~ (p=1.000 n=10) ¹
Slog/no_attrs-16            0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=10) ¹
Slog/3_attrs-16             0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=10) ¹
Slog/5_attrs-16             0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=10) ¹
Slog/10_attrs-16            816.0 ± 0%       816.0 ± 0%       ~ (p=1.000 n=10) ¹
Slog/40_attrs-16          6.469Ki ± 0%     6.469Ki ± 0%       ~ (p=1.000 n=10) ¹
Logr/no_attrs-16            0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=10) ¹
Logr/3_attrs-16             128.0 ± 0%       128.0 ± 0%       ~ (p=1.000 n=10) ¹
Logr/5_attrs-16             208.0 ± 0%       208.0 ± 0%       ~ (p=1.000 n=10) ¹
Logr/10_attrs-16          1.000Ki ± 0%     1.000Ki ± 0%       ~ (p=1.000 n=10) ¹
Logr/40_attrs-16          6.719Ki ± 0%     6.719Ki ± 0%       ~ (p=1.000 n=10) ¹
geomean                                ²                 +0.00%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                        │   old.txt    │               new.txt               │
                        │  allocs/op   │ allocs/op   vs base                 │
Emit/noop/no_attrs-16     0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/noop/3_attrs-16      0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/noop/5_attrs-16      0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/noop/10_attrs-16     1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/noop/40_attrs-16     1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/writer/no_attrs-16   1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/writer/3_attrs-16    4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/writer/5_attrs-16    4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/writer/10_attrs-16   8.000 ± 0%     8.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/writer/40_attrs-16   26.00 ± 0%     26.00 ± 0%       ~ (p=1.000 n=10) ¹
Slog/no_attrs-16          0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
Slog/3_attrs-16           0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
Slog/5_attrs-16           0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
Slog/10_attrs-16          5.000 ± 0%     5.000 ± 0%       ~ (p=1.000 n=10) ¹
Slog/40_attrs-16          8.000 ± 0%     8.000 ± 0%       ~ (p=1.000 n=10) ¹
Logr/no_attrs-16          0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
Logr/3_attrs-16           4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=10) ¹
Logr/5_attrs-16           5.000 ± 0%     5.000 ± 0%       ~ (p=1.000 n=10) ¹
Logr/10_attrs-16          13.00 ± 0%     13.00 ± 0%       ~ (p=1.000 n=10) ¹
Logr/40_attrs-16          40.00 ± 0%     40.00 ± 0%       ~ (p=1.000 n=10) ¹
geomean                              ²               +0.00%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

On go version go1.20 linux/amd64:

goos: linux
goarch: amd64
pkg: go.opentelemetry.io/otel/log/internal
cpu: Intel(R) Core(TM) i9-10885H CPU @ 2.40GHz
                        │ old-go1.20.txt │            new-go1.20.txt            │
                        │     sec/op     │    sec/op     vs base                │
Emit/noop/no_attrs-16        4.801n ± 2%   2.513n ±  4%  -47.67% (p=0.009 n=10)
Emit/noop/3_attrs-16         11.62n ± 2%   12.59n ± 12%   +8.39% (p=0.000 n=10)
Emit/noop/5_attrs-16         15.40n ± 2%   17.30n ±  5%  +12.37% (p=0.000 n=10)
Emit/noop/10_attrs-16        177.3n ± 3%   189.4n ±  8%   +6.80% (p=0.000 n=10)
Emit/noop/40_attrs-16        842.0n ± 3%   882.8n ±  4%   +4.83% (p=0.002 n=10)
Emit/writer/no_attrs-16      83.10n ± 3%   75.88n ± 13%   -8.69% (p=0.029 n=10)
Emit/writer/3_attrs-16       210.4n ± 2%   210.2n ±  2%        ~ (p=0.541 n=10)
Emit/writer/5_attrs-16       243.6n ± 6%   239.4n ±  4%   -1.74% (p=0.043 n=10)
Emit/writer/10_attrs-16      556.3n ± 7%   561.2n ±  7%        ~ (p=0.684 n=10)
Emit/writer/40_attrs-16      2.352µ ± 4%   2.580µ ±  6%   +9.70% (p=0.000 n=10)
Slog/no_attrs-16             109.2n ± 3%   115.0n ± 10%   +5.36% (p=0.001 n=10)
Slog/3_attrs-16              164.7n ± 4%   168.4n ±  4%        ~ (p=0.247 n=10)
Slog/5_attrs-16              192.3n ± 4%   197.9n ±  4%   +2.89% (p=0.043 n=10)
Slog/10_attrs-16             925.9n ± 2%   955.1n ±  4%   +3.15% (p=0.001 n=10)
Slog/40_attrs-16             5.183µ ± 2%   5.280µ ±  2%   +1.87% (p=0.027 n=10)
Logr/no_attrs-16             7.382n ± 7%   7.388n ±  4%        ~ (p=0.912 n=10)
Logr/3_attrs-16              158.6n ± 9%   142.2n ± 13%  -10.31% (p=0.007 n=10)
Logr/5_attrs-16              263.5n ± 6%   221.8n ±  3%  -15.84% (p=0.000 n=10)
Logr/10_attrs-16            1035.0n ± 7%   934.4n ±  2%   -9.72% (p=0.000 n=10)
Logr/40_attrs-16             7.700µ ± 6%   5.295µ ±  2%  -31.23% (p=0.000 n=10)
geomean                      210.5n        200.7n         -4.64%

                        │ old-go1.20.txt │            new-go1.20.txt             │
                        │      B/op      │     B/op      vs base                 │
Emit/noop/no_attrs-16       0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/noop/3_attrs-16        0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/noop/5_attrs-16        0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/noop/10_attrs-16       208.0 ± 0%       208.0 ± 0%       ~ (p=1.000 n=10) ¹
Emit/noop/40_attrs-16     1.375Ki ± 0%     1.375Ki ± 0%       ~ (p=1.000 n=10) ¹
Emit/writer/no_attrs-16     16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=10) ¹
Emit/writer/3_attrs-16      48.00 ± 0%       48.00 ± 0%       ~ (p=1.000 n=10) ¹
Emit/writer/5_attrs-16      48.00 ± 0%       48.00 ± 0%       ~ (p=1.000 n=10) ¹
Emit/writer/10_attrs-16     296.0 ± 0%       296.0 ± 0%       ~ (p=1.000 n=10) ¹
Emit/writer/40_attrs-16   1.695Ki ± 0%     1.695Ki ± 0%       ~ (p=1.000 n=10) ¹
Slog/no_attrs-16            0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=10) ¹
Slog/3_attrs-16             0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=10) ¹
Slog/5_attrs-16             0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=10) ¹
Slog/10_attrs-16            816.0 ± 0%       816.0 ± 0%       ~ (p=1.000 n=10) ¹
Slog/40_attrs-16          6.469Ki ± 0%     6.469Ki ± 0%       ~ (p=1.000 n=10) ¹
Logr/no_attrs-16            0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=10) ¹
Logr/3_attrs-16             128.0 ± 0%       128.0 ± 0%       ~ (p=1.000 n=10) ¹
Logr/5_attrs-16             208.0 ± 0%       208.0 ± 0%       ~ (p=1.000 n=10) ¹
Logr/10_attrs-16          1.000Ki ± 0%     1.000Ki ± 0%       ~ (p=1.000 n=10) ¹
Logr/40_attrs-16          6.719Ki ± 0%     6.719Ki ± 0%       ~ (p=1.000 n=10) ¹
geomean                                ²                 +0.00%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                        │ old-go1.20.txt │           new-go1.20.txt            │
                        │   allocs/op    │ allocs/op   vs base                 │
Emit/noop/no_attrs-16       0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/noop/3_attrs-16        0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/noop/5_attrs-16        0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/noop/10_attrs-16       1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/noop/40_attrs-16       1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/writer/no_attrs-16     1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/writer/3_attrs-16      4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/writer/5_attrs-16      4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/writer/10_attrs-16     8.000 ± 0%     8.000 ± 0%       ~ (p=1.000 n=10) ¹
Emit/writer/40_attrs-16     26.00 ± 0%     26.00 ± 0%       ~ (p=1.000 n=10) ¹
Slog/no_attrs-16            0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
Slog/3_attrs-16             0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
Slog/5_attrs-16             0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
Slog/10_attrs-16            5.000 ± 0%     5.000 ± 0%       ~ (p=1.000 n=10) ¹
Slog/40_attrs-16            8.000 ± 0%     8.000 ± 0%       ~ (p=1.000 n=10) ¹
Logr/no_attrs-16            0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
Logr/3_attrs-16             4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=10) ¹
Logr/5_attrs-16             5.000 ± 0%     5.000 ± 0%       ~ (p=1.000 n=10) ¹
Logr/10_attrs-16            13.00 ± 0%     13.00 ± 0%       ~ (p=1.000 n=10) ¹
Logr/40_attrs-16            40.00 ± 0%     40.00 ± 0%       ~ (p=1.000 n=10) ¹
geomean                                ²               +0.00%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

@pellared pellared mentioned this pull request Jan 25, 2024
Merged
@pellared pellared merged commit ecc26bc into logs-design Jan 26, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pellared