Handle structured body and attributes #7
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Addresses open-telemetry#4809 (comment) and open-telemetry#4809 (comment).
The type definitions need to be compliant with https://opentelemetry.io/docs/specs/otel/logs/data-model/#type-any
What
Here is the code containing new types: https://github.com/pellared/opentelemetry-go/blob/strucutred-values/log/value.go
The code adopted from https://github.com/golang/go/blob/master/src/log/slog/value.go to be compliant with https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/data-model.md#type-any
I am not sure if
uint64
should be handled or not. I decided to postpone it as we can add it later without introducing any breaking change. Spec issue: open-telemetry/opentelemetry-specification#3836.Benchmarks
Even a little faster and consuming less memory.