Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add role permissions for webhooks #742

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Add role permissions for webhooks #742

merged 1 commit into from
Dec 2, 2024
+11 −0

Conversation

Boy132
Copy link
Member

@Boy132 Boy132 commented Dec 1, 2024

No description provided.

@Boy132 Boy132 self-assigned this Dec 1, 2024
RMartinOscar
RMartinOscar requested changes Dec 1, 2024
View reviewed changes
Copy link
Contributor

@RMartinOscar RMartinOscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't view webhook you should be able to access the edit page but everything should be read only (we can even hide events that are not active for better userfriendlyness)
image
image
image

@Boy132
Copy link
Member Author

Boy132 commented Dec 2, 2024

Can't view webhook you should be able to access the edit page but everything should be read only (we can even hide events that are not active for better userfriendlyness)

See #583

@Boy132 Boy132 merged commit bd51191 into pelican-dev:main Dec 2, 2024
15 checks passed
@Boy132 Boy132 deleted the feature/websocket-role-permissions branch December 2, 2024 22:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RMartinOscar RMartinOscar RMartinOscar approved these changes

@notAreYouScared notAreYouScared notAreYouScared approved these changes

Assignees

@Boy132 Boy132

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Boy132 @notAreYouScared @RMartinOscar