Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config panel.editable_server_descriptions check #734

Merged
merged 2 commits into from
Dec 1, 2024
Merged

Add config panel.editable_server_descriptions check #734

merged 2 commits into from
Dec 1, 2024

Conversation

RMartinOscar
Copy link
Contributor

Fixes #733

@RMartinOscar RMartinOscar self-assigned this Dec 1, 2024
@RMartinOscar RMartinOscar mentioned this pull request Dec 1, 2024
Closed
3 tasks
@RMartinOscar RMartinOscar added the 🐛 bug Something isn't working label Dec 1, 2024
Boy132
Boy132 requested changes Dec 1, 2024
View reviewed changes
Copy link
Member

@Boy132 Boy132 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field should be hidden and not just disabled.

@RMartinOscar RMartinOscar merged commit 6d1c153 into pelican-dev:main Dec 1, 2024
15 checks passed
@RMartinOscar RMartinOscar deleted the fix/733 branch December 1, 2024 22:27
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Boy132 Boy132 Boy132 approved these changes

@notAreYouScared notAreYouScared Awaiting requested review from notAreYouScared

Assignees

@RMartinOscar RMartinOscar

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server Description can be edited while it is disabled in the Settings (new client area)
2 participants
@RMartinOscar @Boy132