-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Database Hosts to have multiple Nodes #724
Open
alexevladgabriel
wants to merge
12
commits into
pelican-dev:main
Choose a base branch
from
vehikl:issue-133
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+115
−63
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fa0fc39
WIP
go-vehikl dfe8c67
Update laravel and migrations
go-vehikl 3b75b96
WIP
go-vehikl 85e72d1
fix tests
go-vehikl 5f5d14f
Merge branch 'main' into issue-133
go-vehikl cdff1b5
Update composer
go-vehikl b91d57b
Fix transformer
go-vehikl 4a3a0a0
Fix filament pages
go-vehikl 18a7cc3
WIP
go-vehikl 308f706
Update DatabaseHostTransformer
go-vehikl d8d44d0
fix: tests
go-vehikl 161cf59
pint this files pls
go-vehikl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
database/migrations/2024_10_31_203540_change_database_hosts_to_belong_to_many_nodes.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,48 @@ | ||||||||
<?php | ||||||||
|
||||||||
use Illuminate\Database\Migrations\Migration; | ||||||||
use Illuminate\Database\Schema\Blueprint; | ||||||||
use Illuminate\Support\Facades\Schema; | ||||||||
|
||||||||
return new class extends Migration | ||||||||
{ | ||||||||
public function up(): void | ||||||||
{ | ||||||||
Schema::create('database_host_node', function (Blueprint $table) { | ||||||||
$table->id(); | ||||||||
$table->foreignId('node_id')->references('id')->on('nodes'); | ||||||||
$table->foreignId('database_host_id')->references('id')->on('database_hosts'); | ||||||||
$table->timestamps(); | ||||||||
}); | ||||||||
|
||||||||
$databaseNodes = DB::table('database_hosts')->whereNotNull('node_id')->get(); | ||||||||
$newJoinEntries = $databaseNodes->map(fn ($record) => [ | ||||||||
'node_id' => $record->node_id, | ||||||||
'database_host_id' => $record->id, | ||||||||
'created_at' => now(), | ||||||||
'updated_at' => now(), | ||||||||
]); | ||||||||
|
||||||||
DB::table('database_host_node')->insert($newJoinEntries->toArray()); | ||||||||
|
||||||||
Schema::table('database_hosts', function (Blueprint $table) { | ||||||||
$table->dropForeign(['node_id']); | ||||||||
$table->dropColumn('node_id'); | ||||||||
}); | ||||||||
} | ||||||||
|
||||||||
public function down(): void | ||||||||
{ | ||||||||
Schema::table('database_hosts', function (Blueprint $table) { | ||||||||
$table->foreignId('node_id')->nullable()->references('id')->on('nodes'); | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
}); | ||||||||
|
||||||||
foreach (DB::table('database_host_node')->get() as $record) { | ||||||||
DB::table('database_hosts') | ||||||||
->where('id', $record->database_host_id) | ||||||||
->update(['node_id' => $record->node_id]); | ||||||||
} | ||||||||
|
||||||||
Schema::drop('database_host_node'); | ||||||||
} | ||||||||
}; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.