Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor & Add Port check when creating allocations #684

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Refactor & Add Port check when creating allocations #684

wants to merge 4 commits into from
+242 −218

Conversation

RMartinOscar
Copy link
Contributor

@RMartinOscar RMartinOscar commented Oct 28, 2024 •
edited
Loading

  • Fix PORT_RANGE_LIMIT not enforced
  • Remove duplicated code
  • Catch Rework & Exceptions
  • Add back Expanding Ports
  • Add support for CIDR (Optional)
  • Add IPv6 warning (Optional)
  • Proper Filament rule to validate field
  • CIDR tests (Optional)
  • IPv6 tests (Optional)
    Supersedes: Add Port check when creating allocations #661

@RMartinOscar RMartinOscar self-assigned this Oct 28, 2024
@RMartinOscar RMartinOscar linked an issue Oct 28, 2024 that may be closed by this pull request
Creating an allocation that already exists results in a 500 #655
Open
Boy132
Boy132 requested changes Oct 29, 2024
View reviewed changes
app/Services/Allocations/AssignmentService.php Outdated Show resolved Hide resolved
app/Services/Allocations/AssignmentService.php Outdated Show resolved Hide resolved
app/Services/Allocations/AssignmentService.php Outdated Show resolved Hide resolved
@RMartinOscar RMartinOscar marked this pull request as draft October 29, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boy132 Boy132 Boy132 requested changes

@lancepioch lancepioch Awaiting requested review from lancepioch

Requested changes must be addressed to merge this pull request.

Assignees

@RMartinOscar RMartinOscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating an allocation that already exists results in a 500
2 participants
@RMartinOscar @Boy132