-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/12 bit aiff #218
base: master
Are you sure you want to change the base?
Feature/12 bit aiff #218
Conversation
96d6853
to
54585dd
Compare
54585dd
to
8c8b1c4
Compare
… codedwidth < sample width
As we discussed, the current solution for working with BE encoded files that have a smaller coded width than sample width is correct. symphonia-check will fail on specific 12bit AIFF files, since ffmpeg treats them as 16bit. Because symphonia-codec-pcm is a seperate crate, not specific for RIFF files, we decided to ignore this edge case. That being said, i had some difficulties finding more AIFF and WAVE test files. I did find some, but more testing could not hurt. I did verify with symphonia-check that all test files i used when setting up the RIFF logic still work. |
Hi @dedobbin, Should we also apply the masking logic to LE codecs to be consistent with BE? |
Support for more sample sizes in aiff and wave