core: Clean up Debug formatting of meta::Visual #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can imagine there are situations where you want to see the data, but you can always just print the .data member. So yeah makes sense and lgtm |
|
This PR looks good to me too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the often large and unreadable Debug formatting for the affected type (a raw
[u8]dump for an embedded image file), and replaces the output for data with a manually-formatted type that only shows the data's size. An alternative would be using a wrapper type forBox<u8>that implements this manual debug format on its own, avoiding the possible maintenance burden this PR could have and being reusable for other blob-like data in Symphonia, but this was not chosen as it would likely become a breaking change for relatively little benefit.