Merge pull request #1227 from spc-group/set_many_args

ENH: The set_many utility now works with Ophyd positioners as well as…

pcdsdevices/tests/test_utils.py

@@ -5,12 +5,12 @@
 
 import pytest
 from ophyd import Component as Cpt
-from ophyd import Device, Signal
+from ophyd import Device, PVPositionerDone, Signal
 
 from .. import utils
 from ..device import GroupDevice
 from ..utils import (move_subdevices_to_start, post_ophyds_to_elog,
-                     reorder_components, set_standard_ordering,
+                     reorder_components, set_many, set_standard_ordering,
                      sort_components_by_kind, sort_components_by_name)
 
 try:
@@ -262,3 +262,28 @@ class ChessPieces(Device):
         get_order(ChessPieces)
         == ['queen', 'rook', 'king', 'bishop', 'knight', 'pawn']
     )
+
+
+def test_set_many():
+    """Checks that set_many sets multiple ophyd objects, and that it works
+    with signals as well as positioners.
+
+    Positioners and signals need different keyword arguments to their
+    ``set()`` methods, so this implicitly tests that those are done
+    properly.
+
+    """
+    # Create a dummy positioner with an extra signal
+    class MyPositioner(PVPositionerDone):
+        setpoint = Cpt(Signal)
+        another_signal = Cpt(Signal)
+
+    device = MyPositioner()
+    assert device.done.get() == 0
+    # Set the positioner and the extra signal together
+    st = set_many({device: 5, device.another_signal: 7}, raise_on_set_failure=True)
+    st.wait(timeout=3)
+    # Check that all the signals were set properly
+    assert device.done.get() == 1
+    assert device.setpoint.get() == 5
+    assert device.another_signal.get() == 7