Skip to content

Commit

Permalink
Tweak CRAN comments
Browse files Browse the repository at this point in the history
  • Loading branch information
seananderson committed Jan 27, 2023
1 parent 2b26310 commit d3744b8
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,18 @@

This is a resubmission to fix 'Additional issues' on CRAN checks as requested.

We were unable to reproduce the issue but have removed tangential functionality
that used rstan, which appears to have caused valgrind/gcc-ASAN/clang-ASAN
errors on CRAN checks.
We were unable to reproduce the exact valgrind/gcc-ASAN/clang-ASAN issue
identified in our re-submission (0.2.2), but have removed tangential
functionality that used 'rstan', which appears to have caused the errors on
the last CRAN checks.

We have tested the new package with valgrind on two systems and clang-ASAN on
the latest Fedora attempting to match the CRAN setup and our checks pass.
We have tested the new package with valgrind on two systems and
with clang-ASAN/clang-UBSAN on the latest Fedora attempting to match the CRAN
setup and our checks pass.

Compared to the previously published version 0.2.1:

* We fixed a valgrind-detected issue with a vector length.
* We removed 2 Latin-1 strings in package data.
* We added 'future' and 'lme4' to Suggests to avoid 'Rd cross-references'
'Undeclared packages' NOTE.
Expand Down Expand Up @@ -43,10 +46,10 @@ checking installed package size ... NOTE
* Windows (on github-actions), R 4.2.2
* Ubuntu 20.04.4 (on github-actions), R-devel
* Windows (winbuilder), R devel
* Windows Server 2022 (R-hub), R-devel, 64 bit
* Windows (winbuilder), R release

With sanitizer checks:

* Fedora release 38 (on docker), R-devel with clang ASAN
* Fedora release 38 (on docker), R-devel with clang ASAN, clang-UBSAN
* Ubuntu 20.04.4 (on github-actions), R-devel with valgrind
* Ubuntu 20.04.4 (on docker), R-devel with valgrind level 2 instrumentation

0 comments on commit d3744b8

Please sign in to comment.