fix(core): slotController isEmpty respects text nodes

patternfly · Nov 20, 2024 · e5103c5 · e5103c5
1 parent fe349ea
commit e5103c5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/olive-rivers-stick.md b/.changeset/olive-rivers-stick.md
@@ -0,0 +1,4 @@
+---
+"@patternfly/pfe-core": patch
+---
+`SlotController`: `hasContent`/`isEmpty` now respects text nodes
diff --git a/core/pfe-core/controllers/slot-controller.ts b/core/pfe-core/controllers/slot-controller.ts
@@ -193,7 +193,8 @@ export class SlotController implements ReactiveController {
       ?? this.#getChildrenForSlot(name);
     const selector = slotName ? `slot[name="${slotName}"]` : 'slot:not([name])';
     const slot = this.host.shadowRoot?.querySelector?.<HTMLSlotElement>(selector) ?? null;
-    const hasContent = !!elements.length;
+    const nodes = slot?.assignedNodes?.();
+    const hasContent = !!elements.length || !!nodes?.filter(x => x.textContent?.trim()).length;
     this.#nodes.set(name, { elements, name: slotName ?? '', hasContent, slot });
     this.#logger.debug(slotName, hasContent);
   };