Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignored labels #20

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Ignored labels #20

wants to merge 21 commits into from

Conversation

bretg
Copy link

@bretg bretg commented Nov 17, 2024

We're planning to use Stale PR Finder to help manage the backlogs for the open source project https://github.com/prebid, but we needed to ability to flag certain PRs as excluded from being considered stale. Added the ignoredLabels feature for your consideration.

Thank you.

@bretg bretg requested a review from a team as a code owner November 17, 2024 18:13
Copy link
Contributor

@Bullrich Bullrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR seems good.

I have a question though, wouldn't it make sense to use the requiredLabel feature and add it to PRs when needed? Or do you have a big influx of PRs and want to manually remove the label as "ready to review"?

You should also update the package version and action version to 0.3.0 so it automatically updates.

Remember to run yarn run fix to fix the linting issues.

@lovelaced and @mordamax, can you please look into reviewing this PR too?
Also, why didn't it automatically assign the opstooling team?

src/index.ts Outdated Show resolved Hide resolved
Co-authored-by: Javier Bullrich <[email protected]>
@bretg
Copy link
Author

bretg commented Nov 18, 2024

Thanks for looking into this

wouldn't it make sense to use the requiredLabel feature and add it to PRs when needed? Or do you have a big influx of PRs big influx of PRs

we get on the order of about 10 PRs/week, so we might not remember to label each one. Less friction in our workflow to label the special cases... "Needs OP" and "Next Major Release" are two scenarios where PRs can sit around for a while.

You should also update the package version and action version to 0.3.0 so it automatically updates.

Remember to run yarn run fix to fix the linting issues.

Will work to figure these out, but may be a few days. Thanks for your patience.

@bretg
Copy link
Author

bretg commented Nov 18, 2024

Ok, made some changes for the release and lint. Not very confident in this area - appreciate your feedback.

@bretg
Copy link
Author

bretg commented Nov 19, 2024

Fixed a couple more linting issues

@bretg bretg requested a review from mordamax November 21, 2024 20:40
@bretg
Copy link
Author

bretg commented Nov 25, 2024

Does this look ok now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants