Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential github action smells #9672

Open
wants to merge 2 commits into
base: v2
Choose a base branch
from

Conversation

ceddy4395
Copy link

@ceddy4395 ceddy4395 commented Apr 26, 2024

Hey! 🙂
I want to contribute the following changes to your workflow:

  • Avoid running CI related actions when no source code has changed
  • Use 'if' for upload-artifact action
  • Avoid uploading artifacts on forks
  • Stop running workflows when there is a newer commit in PR

(These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more

↪️ Pull Request

💻 Examples

🚨 Test instructions

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

- Avoid running CI related actions when no source code has changed
- Use 'if' for upload-artifact action
- Avoid running CI related actions when no source code has changed
- Stop running workflwos when there is a newer commit in PR
- Cargo.toml
- Cargo.lock
- babel.config.json
- sciprts/**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be scripts?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, typo on my side, appologies! I've also fixed this in ci.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants