refactor: unify code paths for receipts removal #12887
Open
+250
−206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unifies code paths for receipts removal which is happening in
take_state_above
(used by legacy engine andExecutionStage
unwind and inremove_state_above
(used by new engine and unwind through cli)New function
DatabaseProvider::remove_receipts_from
is introduced which accepts the starting receipt number to remove andStorageLocation
and removes receipts from database/static filesThis PR also includes a fix for
take_state_above
which might've returned incorrect receipts data inExecutionOutcome
if receipts were removed from database. It did not account for receipts being pruned or moved to static files.