Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default impl BlockBody::recover_signers #12826

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Default impl BlockBody::recover_signers #12826

wants to merge 4 commits into from
+39 −5

Conversation

emhane
Copy link
Member

@emhane emhane commented Nov 24, 2024

Ref #12575

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-sdk Related to reth's use as a library labels Nov 24, 2024
This was referenced Nov 24, 2024
Open
Open
mattsse
mattsse reviewed Nov 24, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, don't think we should make this the default impl, because this embeds rayon at the root of the abstraction

crates/primitives-traits/src/block/body.rs
@@ -29,8 +45,17 @@ pub trait BlockBody:
+ MaybeArbitrary
{
/// Ordered list of signed transactions as committed in block.
type Transaction: Transaction;
type Transaction: SignedTransaction;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do this separately?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse