Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken sql table name validation example #557

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Fix broken sql table name validation example #557

merged 2 commits into from
Nov 19, 2024

Conversation

dekatzenel
Copy link
Contributor

Background

https://panther-labs.slack.com/archives/C0719AH18SV/p1731965902688019

Changes

  • Adds handling of simple dict table parse case

Testing

  • Added unit test using example provided that failed before and passes now
  • Not sure if it works in all cases, but it took a while for any customer to complain about this case, so we can fix future cases as the need arises

@dekatzenel dekatzenel force-pushed the dana-katzenelson-table-name-validation-dict branch from f6ccc74 to 801a611 Compare November 18, 2024 23:01
@dekatzenel dekatzenel marked this pull request as ready for review November 18, 2024 23:08
maxrichie5
maxrichie5 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@maxrichie5 maxrichie5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand how this work but the code seems fine to me

@dekatzenel dekatzenel enabled auto-merge (squash) November 19, 2024 19:38
@dekatzenel dekatzenel merged commit 1548a27 into main Nov 19, 2024
3 checks passed
@dekatzenel dekatzenel deleted the dana-katzenelson-table-name-validation-dict branch November 19, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxrichie5 maxrichie5 maxrichie5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dekatzenel @maxrichie5