Update stairs / Alias stairs nodes to stairsplus

[OgelGames]

Working on mt-mods/technic#224, I noticed a problem with stairs nodes, they are registered in minetest.after which causes them to have a mod_origin of ??, and also prevents them from being changed by technic_worldgen.

TenPlus1's version doesn't have that problem, so it might be good to switch to that.

EDIT: see below.

[OgelGames]

Weird... works for the tests, but not locally...

TenPlus1's stairs doesn't check its dependencies correctly, the old (current) version uses minetest.after to get around that, but that causes problems.

EDIT: and adding optional dependencies doesn't work, causes circular dependencies... :/

[OgelGames]

I think the best solution for this would be to remove the stairs mod, and alias everything to stairsplus nodes (even the nodes that will still be registered by MTG's stairs mod), that should reduce the registered node count significantly, and fix the other problems.

[BuckarooBanzay]

causes them to have a mod_origin of ??

Nice, i always wondered how this was caused

I think the best solution for this would be to remove the stairs mod, and alias everything to stairsplus nodes

Sounds good, i'm still not sure where i got the current stairs mod from, i think i copied it from the forums into a server of mine in the early days and copied it along from world to world until it ended up here :/
Anyway: 👍 for replacing that, will make the recipes a bit clearer too (no duplicates)

Any ideas how to generate an alias list? doing this by hand sounds like a nightmare

[OgelGames]

Any ideas how to generate an alias list? doing this by hand sounds like a nightmare

One way I thought of was making a "fake" stairs mod, that instead of registering the nodes, called the stairsplus api, and also aliased the nodes. This would also prevent the recipes for them being added, which is probably a good thing.

I haven't figured out if that is possible yet, or what would happen if the node names were changed (double aliases), but I do know that there are 381 stairs:* nodes currently...

[OgelGames]

<Huhhila> https://github.com/random-geek/morelights/blob/717553c9cb5faf779dae6df5d9aea2e1674fc242/morelights_extras/init.lua#L181 doesn't appear to be compatible with aliases.