String dtype: coerce missing values in indexers for string dtype Index #60454
+26
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Indexing
WillAyd
approved these changes
Dec 2, 2024
|
lgtm. I don't think the macOS failures are related? |
mroeschke
reviewed
Dec 2, 2024
Comment on lines
+6224
to
+6227
| # elif self.dtype == "string" and other.dtype == "object": | ||
| # if lib.is_string_array(other._values, skipna=True): # type: ignore[arg-type] | ||
| # return self, other.astype(self.dtype) | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59879
Re-taking part of the changes in #60329 that I had removed from that PR to let that just focus on fixing looking up its "native" missing value for string dtype. This PR then relaxes that restriction to allow looking up other missing values as well.