Fix junit5 excavator #2631
Open
Fix junit5 excavator #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SafeLoggingPropagation uses new ASTHelpers.isRecord function
#2537) StrictUnusedVariable is not suppressed when UnusedVariable is disabled
[skip ci]
#2530) Add check: Use Collection.isEmpty() instead of comparing size() with 0
[skip ci]
[skip ci]
Add a line for an error-prone check added in #655, which is missing from the README.
…Exception (#2541) Add check: Use InvocationTargetException.getCause instead of getTargetException.
[skip ci]
No longer suggest the "Save Actions" IntelliJ plugin which does not work in IntelliJ 2023.1 for use with Palantir Java Format. Instead, Palantir Java Format will support the IntelliJ native "Actions on save" reformat capability in a future release.
[skip ci]
Prefer InputStream.transferTo(OutputStream) Add error-prone check to automate migration to prefer `InputStream.transferTo(OutputStream)` instead of utility methods such as Guava's `com.google.common.io.ByteStreams.copy(InputStream, OutputStream)`. Allow for optimization when underlying input stream (such as `ByteArrayInputStream`, `ChannelInputStream`) overrides `transferTo(OutputStream)` to avoid extra array allocations and copy larger chunks at a time (e.g. allowing 16KiB chunks via `ApacheHttpClientBlockingChannel.ModulatingOutputStream` from #1790). When running on JDK 21+, this also enables 16KiB byte chunk copies via `InputStream.transferTo(OutputStream)` per [JDK-8299336](https://bugs.openjdk.org/browse/JDK-8299336), where as on JDK < 21 and when using Guava `ByteStreams.copy` 8KiB byte chunk copies are used. References: * palantir/hadoop-crypto#586 * https://bugs.openjdk.org/browse/JDK-8299336 * https://bugs.openjdk.org/browse/JDK-8067661 * https://bugs.openjdk.org/browse/JDK-8265891 * https://bugs.openjdk.org/browse/JDK-8273038 * https://bugs.openjdk.org/browse/JDK-8279283 * https://bugs.openjdk.org/browse/JDK-8296431 Closes #2615
[skip ci]
Improve SafeLoggingPropagation on Immutables, taking into account fields from superinterfaces
[skip ci]
Upgrade error-prone to 2.21.1 (from 2.19.1)
[skip ci]
…adle 7 and 8 (#2605) Use a `Proxy` for `JavaInstallationMetadata` so we can work across Gradle 7 and 8.
[skip ci]
`baseline-exact-dependencies` is now far more lazy around `Configuration` creation in order to support Gradle 8.
[skip ci]
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
JUnit 5 excavator #2487 is broken
After this PR
==COMMIT_MSG==
Fix junit5 excavator
==COMMIT_MSG==
Possible downsides?