Remove endpoints from schema pulls if other node is down (#594)

palantir · Dec 7, 2024 · 627a5dc · 627a5dc
1 parent 6aad1ab
commit 627a5dc
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/src/java/org/apache/cassandra/service/MigrationTask.java b/src/java/org/apache/cassandra/service/MigrationTask.java
@@ -63,6 +63,7 @@ public void runMayThrow() throws Exception
         if (!FailureDetector.instance.isAlive(endpoint))
         {
             logger.warn("Can't send schema pull request: node {} is down.", endpoint);
+            version.ifPresent(v -> MigrationManager.removeEndpointFromSchemaPullVersion(v, endpoint));
             return;
         }
 
@@ -72,6 +73,7 @@ public void runMayThrow() throws Exception
         if (!MigrationManager.shouldPullSchemaFrom(endpoint))
         {
             logger.info("Skipped sending a migration request: node {} has a higher major version now.", endpoint);
+            version.ifPresent(v -> MigrationManager.removeEndpointFromSchemaPullVersion(v, endpoint));
             return;
         }
 
@@ -124,6 +126,12 @@ public boolean isLatencyForSnitch()
                 return false;
             }
         };
-       MessagingService.instance().sendRRWithFailure(message, endpoint, cb);
+        try {
+            MessagingService.instance().sendRRWithFailure(message, endpoint, cb);
+        }
+        catch (Exception e)
+        {
+            version.ifPresent(v -> MigrationManager.removeEndpointFromSchemaPullVersion(v, endpoint));
+        }
    }
 }